Desktop pc or laptop in 2018 ?

As the others have said, it depends on what you're wanting to do. If you're wanting to get something that you can move around and use, go for a laptop, but if you're looking into something (like a gaming rig) that sits in one place, get a desktop.